Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lintly GitHub Actions has stopped working in the last few days #41

Open
JMMarchant opened this issue Oct 22, 2020 · 2 comments
Open

Lintly GitHub Actions has stopped working in the last few days #41

JMMarchant opened this issue Oct 22, 2020 · 2 comments

Comments

@JMMarchant
Copy link

We've been using Lintly and flake8 on our GitHub Actions but over the last few days it seems to have stopped working (no longer posts PR approvals or reviews). Was just wondering if there had been any changes that might explain it; the job is running and finished, it just doesn't post the review/approval.

Here's out GitHub Actions config:

name: Lint

on: [pull_request]

jobs:
  # Black formatting check
  black:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2
      - name: Setup Python
        uses: actions/setup-python@v2
      - name: Run Black code formatter
        uses: psf/black@stable

  # flake8 check
  flake8:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2
      - name: Setup Python
        uses: actions/setup-python@v2
      - name: Install flake8 and plugins
        run: pip install \
                flake8 \
                flake8-bugbear \
                lintly
      - name: Run flake8 linter
        run: flake8 | lintly
        env:
          LINTLY_API_KEY: ${{ secrets.GITHUB_TOKEN }}
@amin-nejad
Copy link

However if there is a formatting problem which flake8 raises, the github-actions bot will still request a change. But it will then be stuck in that state even after a commit is pushed which addresses the request. Meaning the PR effectively has to be closed and a new one opened.

@grantmcconnaughey
Copy link
Owner

Oof, that's no good. I released version 0.6.0 a few days ago, and I'm guessing that's the issue. Please pin to 0.5.0 until I get a chance to debug this.

joshuacwnewton added a commit to spinalcordtoolbox/spinalcordtoolbox that referenced this issue Feb 9, 2021
renefritze pushed a commit to renefritze/Lintly that referenced this issue Feb 21, 2022
…l-output

SEC-1704 Fixed parsers to handle when parsers return no findings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants