add gfql colab links to readme #547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lmeyerov
reviewed
Feb 23, 2024
| @@ -42,7 +42,7 @@ def unique_flatten_dict(d): | |||
| } | |||
|
|
|||
| base_extras_heavy = { | |||
| 'umap-learn': ['umap-learn', 'dirty-cat==0.2.0', 'scikit-learn>=1.0'], | |||
| 'umap-learn': ['umap-learn', 'dirty-cat==0.2.0', 'scikit-learn<=1.3.2'], | |||
There was a problem hiding this comment.
maybe we keep >=1.0 here, and make just ci require <=1.3.2? I don't want to mess up people's installs as we're just one lib of many
also, do we know what's going on here?
There was a problem hiding this comment.
ok i moved this guidance to test deps in #548, so you can rebase as that lands
|
I'm not sure what this improves -- the notebooks are already linked on viewables in the github -- and notebooks should be on org accounts? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.