Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that the user has sufficient DAI balance before submitting listing #210

Open
juanmardefago opened this issue Mar 11, 2021 · 1 comment · May be fixed by #211
Open

Validate that the user has sufficient DAI balance before submitting listing #210

juanmardefago opened this issue Mar 11, 2021 · 1 comment · May be fixed by #211

Comments

@juanmardefago
Copy link

Right now you can submit a listing without enough DAI to pay for the listing fee, which results in users being able to submit a listing that will fail and cost them ETH in gas fees anyways.

We shouldn't let them submit the listing if they don't meet the criteria for the listing to succeed, to avoid any unexpected economic issue for the end user.

@juanmardefago
Copy link
Author

@nenadjaja not sure who's in charge of development on the everest site though, you probably know better than me :)

@Cyclic Cyclic linked a pull request Mar 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant