Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to graphene v3 ? #66

Open
ldynia opened this issue May 10, 2021 · 8 comments
Open

Update to graphene v3 ? #66

ldynia opened this issue May 10, 2021 · 8 comments

Comments

@ldynia
Copy link

ldynia commented May 10, 2021

Hi @SmileyChris

I am wondering if you are gonna create a pre-release of the project to support graphene 3, and when would that be ?

Best

@ldynia ldynia changed the title When will update to graphene v3 ? Update to graphene v3 ? May 13, 2021
@f-tepel
Copy link

f-tepel commented Jul 6, 2021

Would love to have that as well!

@SmileyChris
Copy link
Contributor

@ldynia and @f-tepel -- got any time to help with that? I'd love to get a graphene 3 branch underway.

@f-tepel
Copy link

f-tepel commented Jul 7, 2021

What would have to be done? (I am new to open-source) @SmileyChris

@pgzmnk
Copy link

pgzmnk commented Dec 24, 2021

@ceelian
Copy link

ceelian commented Jul 24, 2022

Also looking forward how/if it is working with graphene v3

@jtc3161
Copy link

jtc3161 commented May 2, 2023

Hey if anyone is interested, I have a github repo here: https://github.com/jtc3161/graphql-ws-aiohttp that is a fork of https://github.com/dls-controls/graphql-ws-aiohttp, which was written by @callumforrester who posted #90 a while back.

I have:

  • implemented the newer "graphql-transport-ws" protocol ("graphql-ws" was deprecated a while back)
  • production tested against both the python and Typescript graphql-ws client implementations, with android, ios and web clients actively using it.

Some of my thoughts:

  • maybe we should support both graphql-ws and graphql-transport-ws as a way to support older clients, though the Typescript server does not do this, so I didn't either in this repo.
  • This is a downstream fork of graphql-ws-next and not graphql-ws. graphql-ws next is much closer to the typescript reference implementation though so I do not think that is a downside.

Unfortunately I'm neck deep in the project that I built this for, so the repo is not exactly up to the standards of most oss projects, but I could definitely spend some time fleshing this out more if there is any buy in from maintainers.

@erikwrede
Copy link
Member

@jtc3161 awesome work! Maybe there's a way to integrate this with graphql-server so we reduce the amount of libraries we need to maintain. /cc @kiendang

Feel free to join our discord server and ping us there!

https://discord.gg/UszdMbZhdc

@kiendang
Copy link

There's an implementation for Subscriptions via WebSocket in the v3 branch of graphql-python/graphql-server. I've create graphql-python/graphql-server#112 to track making official support for it. As Erik said if you're interested in GraphQL Subscriptions for Graphene 3 please join the Discord server to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants