Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] CDN usage & examples should move from umd to esm #3775

Open
acao opened this issue Sep 10, 2024 · 0 comments
Open

[graphiql] CDN usage & examples should move from umd to esm #3775

acao opened this issue Sep 10, 2024 · 0 comments

Comments

@acao
Copy link
Member

acao commented Sep 10, 2024

es6-module support is now available in safari and most of the browsers our potential users would be using

https://caniuse.com/es6-module

For graphql@4 or graphql@5, we should maintain a deprecated legacy support for UMD, but switch our documentation, examples, and primary bundle to use es6 modules natively in the browser

two options:

  1. we decide to "progressively enhance" and bundle graphiql.min.js and graphiql.js as es6 compatible modules, and add graphiql.umd(.min).js bundles for those who still need UMD
  2. the more cautious approach would be the opposite of the above - continue publishing the canonical bundles with UMD, and add a graphiql.esm.min.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant