Handle options requests #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
force-pushed
the
fix-optins
branch
from
04f024c to
416b3d6
Compare
|
Hi @JoviDeCroock ! Thank you for helping move it forward! May I know when we could merge this PR? 🙂 |
|
@eddeee888 when this gets reviewed |
enisdenjo
approved these changes
Jan 6, 2025
|
Thanks @JoviDeCroock ! https://graphql.org/swapi-graphql/ is still not working for me 🤔 |
|
There's two more PR's in the pipeline to fully fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229
Fixes #184
We weren't handling CORS