Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CICD releases aren't setting the pre-release flag correctly in Github's release action #13

Open
daxpryce opened this issue Nov 2, 2020 · 1 comment
Open

CICD releases aren't setting the pre-release flag correctly in Github's release action #13

daxpryce opened this issue Nov 2, 2020 · 1 comment
Assignees
@jonmclean

Comments

@daxpryce
Copy link
Contributor

daxpryce commented Nov 2, 2020

We release on merge/push to dev or main. If on dev, we want the prerelease flag to be set - we also pick a version number that indicates a pre-release to PyPI.

I thought we were doing that, but it seems to be not working. As it is now I'm constantly marking it as pre-release after the fact and I'd prefer I didn't have to do that. At the least set it to true at all times and I'll manually set it to false later.
@daxpryce
Copy link
Contributor Author

So I thought I had fixed this, but it still seems like the prerelease flag is just straight up ignored. I can conditionally run an action depending on branch and hardcode the true/false but it's galling that I have to.

I hate trying to track down CICD issues >.<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonmclean jonmclean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daxpryce @jonmclean