Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing "write + read" permissions from docs #292

Open
vincerubinetti opened this issue Dec 10, 2024 · 0 comments
Open

Investigate removing "write + read" permissions from docs #292

vincerubinetti opened this issue Dec 10, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@vincerubinetti
Copy link
Collaborator

It turns out I may have been misunderstanding the (imo complex) hierarchy of GitHub permissions. I think since I've specified the specific permissions I need in each workflow file, the user shouldn't have to change their repo to "write + read" in the Actions settings.

I could've sworn in past testing that even with the permissions field, you still needed "write + read" in the settings, but testing something just now with the Dashnow lab, it appears that you don't. I still want to test this thoroughly before removing it from the docs, because there's places where it could still fail. E.g. maybe it works for orgs but not regular users, or maybe it works when doing a PR from a branch but not a fork 🤷

I think the user would still need to check "allow actions to open PRs" for the on-schedule citation update.

@vincerubinetti vincerubinetti added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant