Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in simulate_k when number of teams are different #5

Open
kmcnayr opened this issue Oct 29, 2023 · 1 comment
Open

Error in simulate_k when number of teams are different #5

kmcnayr opened this issue Oct 29, 2023 · 1 comment

Comments

@kmcnayr
Copy link

kmcnayr commented Oct 29, 2023

In examples/notebook2 I am receiving an error after changing Magmaguard team to a third team name in the starwars-cloneswars.csv dataset.

The issue appears to be due to the battle now containing 3 teams after loading the unit dataset file, but the simulate_battle is only returning a result for the unique teams in M.

Generically: this error happens when the number of unique teams loaded into the battle object is different than the number of teams that are added via create_armies

Solution: I suppose you can just make sure to add armies for all of the teams that are loaded into the battle object.

I found this when playing around with examples/notebook2 which loads a number of units from the csv dataset file but only runs a sim using two unit types which are in three army groups, and represent only two of the three unique teams in the dataset file (after I changed the Magmaguard to a third team name).

@gregparkes
Copy link
Owner

See #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants