Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matching to more OSM object types #30

Open
osmuser63783 opened this issue Oct 12, 2024 · 1 comment
Open

Allow matching to more OSM object types #30

osmuser63783 opened this issue Oct 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@osmuser63783
Copy link

osmuser63783 commented Oct 12, 2024

Hi, this is a great tool. I've just spent some time matching objects.

Quite often I find that an object in the FHRS data has a corresponding object in the OSM data but I can't select the OSM object because FHODOT only allows matching with a limited set of OSM object types (e.g. cafe, bar, restaurant). At the moment my workflow, when I can see the OSM object on the map but can't select it, is to download the area manually in JOSM to add the tags manually. But this is a bit tedious and I am wondering if it can be made easier.

It would be nice to either expand the set of OSM objects that can be selected, or add a button that lets me toggle between the limited set and a view that shows all shop, amenities, etc.

Some of the more "niche" object types that I have found to have FHRS ratings include

amenity=theatre

amenity=place_of_worship

shop=gift

amenity=courthouse

office=

leisure=fitness_centre

Arguably in some of these cases the theatre / gym / government building .. has a bar inside that could be mapped separately, but when these aren't open to the general public, don't have their own names, opening hours, websites, etc. we don't tend to map them separately. In other cases I'm not sure why the object has an FHRS ID at all, but I am still sure it's a match. (Maybe they have a kitchen that is only used for events? Again not something we normally map separately.)

@gregrs-uk gregrs-uk added the enhancement New feature or request label Oct 22, 2024
@gregrs-uk
Copy link
Owner

Thanks for your detailed comment.

I've previously (see #13) used some areas with a large proportion of FHRS establishments matched to OSM objects to assess the relevance of particular tags.

I've just re-run this analysis with up-to-date data for the Derby, Bath & NE Somerset, Broxtowe and Erewash local authority districts, which are all very well matched. The proportions of the OSM objects you've suggested that were matched to FHRS establishments in these regions are as follows:

amenity=theatre: 33%
amenity=place_of_worship: 23%
shop=gift: 21%
amenity=courthouse: 20%
office=: variety of values from 2% to 38%
leisure=fitness_centre: 13%

There's a tradeoff between making it quick to match objects and not showing too many objects that are unlikely to be matchable, which could clutter the map view. I've previously used 50% as an approximate cutoff. So in that case, none of the above would qualify.

In evaluating again, I found the following:

amenity=pharmacy is right on the borderline with 52%
amenity=club should probably be included with 74%, or the sub-tag club=school with 91%
amenity=hospital also has 62%

It would be pretty quick to change the list of tags.

It would be nice to […] add a button that lets me toggle between the limited set and a view that shows all shop, amenities, etc.

This sounds like a nice idea, but would take longer to implement and I wouldn't have time at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants