Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] rename dirichlet_tags to simply tags #631

Open
fverdugo opened this issue Jul 26, 2021 · 0 comments
Open

[Proposal] rename dirichlet_tags to simply tags #631

fverdugo opened this issue Jul 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@fverdugo
Copy link
Member

Now:

V = TestFESpace(model,reffe,dirichlet_tags="dirichlet") # <-- note here
Ω = Triangulation(model,tags="domain")
Γ = BoundaryTriangulation(model,tags="neumann")

Proposal:

V = TestFESpace(model,reffe,tags="dirichlet") # <-- note here
Ω = Triangulation(model,tags="domain")
Γ = BoundaryTriangulation(model,tags="neumann")

This would lead to less writing and be more consistent with the other constructors. The change is feasible since we only have (and will possibly always have) one kind of tags in the FESpace constructor. In addition, it would fix gridap/Tutorials#78

@fverdugo fverdugo added the enhancement New feature or request label Jul 26, 2021
@fverdugo fverdugo added this to the v0.17 milestone Jul 26, 2021
@fverdugo fverdugo removed this from the v0.17 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant