Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor influxdb queries #68

Open
yashvardhan-kukreja opened this issue Feb 1, 2021 · 1 comment · May be fixed by #144
Open

refactor influxdb queries #68

yashvardhan-kukreja opened this issue Feb 1, 2021 · 1 comment · May be fixed by #144
Labels
good first issue Good for newcomers tech debt Changes to the codebase like cleanups, refactors, etc. which don't affect the codebase functionally.

Comments

@yashvardhan-kukreja
Copy link
Contributor

Look for the jinja templates with data_source_type as InfluxDB and refactor the queries in them to replace " with ` .

Ref: https://github.com/grofers/legend/blob/master/legend/metrics_library/metrics/platform_ec2_metrics.j2
@yashvardhan-kukreja yashvardhan-kukreja added good first issue Good for newcomers tech debt Changes to the codebase like cleanups, refactors, etc. which don't affect the codebase functionally. labels Feb 1, 2021
@yashvardhan-kukreja yashvardhan-kukreja changed the title refactor: convert " to ‘ for influxdb queries refactor influxdb queries Feb 1, 2021
@duttaANI duttaANI linked a pull request Nov 3, 2021 that will close this issue
Open
@duttaANI
Copy link

duttaANI commented Nov 3, 2021

@yashvardhan-kukreja Could you review the PR

PrayagS pushed a commit that referenced this issue Apr 6, 2022
@vivekyadavgf
Merge pull request #68 from grofers/add-django-alerts
f7f25c6 
Add django alerts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers tech debt Changes to the codebase like cleanups, refactors, etc. which don't affect the codebase functionally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: refactor queries duttaANI/legend
2 participants
@yashvardhan-kukreja @duttaANI