New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsArrayList.contains() doesn't work in IE8 #4

Open

ks280first opened this issue Feb 4, 2015 · 1 comment

ks280first commented Feb 4, 2015

Evidently IE 8 and earlier is missing Array.indexOf() which causes JsArrayList.contains() to break.

Fix was simple once I figured out what was going on. Maybe this could be included in the implementation.

<script> if (!Array.prototype.indexOf) { Array.prototype.indexOf = function(elt /*, from*/) { var len = this.length >>> 0; var from = Number(arguments[1]) || 0; from = (from < 0) ? Math.ceil(from) : Math.floor(from); if (from < 0) from += len; for (; from < len; from++) { if (from in this && this[from] === elt) return from; } return -1; }; } </script>

Member

reinert commented Feb 4, 2015

I would happily accept a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment