Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to bazelmod #618

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Switch to bazelmod #618

wants to merge 2 commits into from

Conversation

ratnikov
Copy link

@ratnikov ratnikov commented Jun 8, 2024

Resolves #398

I'm open to which version to pick, just happy I can depend on grpc-kotlin using bazel mod. :)

Copy link

linux-foundation-easycla bot commented Jun 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@ed-irl
Copy link

ed-irl commented Jul 19, 2024

@ratnikov I was just lurking on the issue that this patch is targeted towards. Is there an alternative/competing patch thats not listed on the issue? Nice work regardless, it would be good to see bzlmod support. Hopefully you're able to get the CLA and stuff and find a reviewer 😄 🤞

@ratnikov
Copy link
Author

I'm not aware of any alternative work. I've been using my patch internally for a bit, so so far it works. :)

We've been making some progress on our end to get the EasyCLA hurdle out of the way, so I'm hopping that that will be green in a week or two. I have a feeling that may elicit some input from maintainers on its mergability.

@gonzojive
Copy link

Is anything blocking review of this? It seems the CLA has been signed.

@ratnikov
Copy link
Author

@lowasser hey, looks like you merged last few commits. Could you help me understand what's the best process to follow to proceed with the review of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Bzlmod
3 participants