From 20790fc2597971b6eaada36fbeaf5d3c95d54d93 Mon Sep 17 00:00:00 2001 From: Eryu Xia Date: Mon, 24 Jun 2024 22:41:24 -0700 Subject: [PATCH] Revert "Revert "Temporarily disable `protoc-plugin` in CI"" (#1451) * Revert "Revert "Temporarily disable protoc-plugin in CI (#1447)" (#1448)" This reverts commit e6909cd2841061aa409e7f9365ac68b865fd8f83. * Update run_basic_tests.sh --- scripts/run_basic_tests.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/run_basic_tests.sh b/scripts/run_basic_tests.sh index 6e0286e44..6f3cde276 100755 --- a/scripts/run_basic_tests.sh +++ b/scripts/run_basic_tests.sh @@ -68,7 +68,13 @@ docker-compose down echo -e "\n[Running] Basic test #3 - Testing everything buids" if [[ "$MASTER" == "1" ]]; then # Build all for continuous_integration - docker-compose build + # docker-compose build + + # Temporary fix `protoc-plugin` build failure (introduced in + # https://github.com/grpc/grpc-web/pull/1445) by building + # everything but it. + # TODO: Revert to building all targets. + docker-compose build prereqs echo-server node-server node-interop-server envoy grpcwebproxy commonjs-client closure-client ts-client binary-client interop-client jsunit-test else # Only build a subset of docker images for presubmit runs docker-compose build commonjs-client closure-client ts-client