Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Docsy card- and tabpane-shortcode style workarounds #1030

Open
chalin opened this issue Aug 12, 2022 · 2 comments
Open

Revert Docsy card- and tabpane-shortcode style workarounds #1030

chalin opened this issue Aug 12, 2022 · 2 comments
Labels
docsy e0-minutes Effort: < 60 min style Front-end site design / styling upstream

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 12, 2022

#1027 introduced the following style workaround google/docsy@v0.4.0...grpc:grpc.io-docsy:grpc.io-upto-doccsy-0.4.0#diff-1f4d7b8618cd04fd8c5bf1b1dc08c5ae99ade3e2418c79d1e8f2acaa07a90923:

image

Undo this override once the original issue (google/docsy#1154) is fixed and merged into grpc.io-docsy.
@chalin chalin added e0-minutes Effort: < 60 min style Front-end site design / styling docsy upstream labels Aug 12, 2022
@chalin chalin changed the title Revert Docsy card-shortcode style workaround Revert Docsy card- and tabpane-shortcode style workarounds Aug 12, 2022
@eugeneo
Copy link
Contributor

eugeneo commented Apr 12, 2023

@chalin Is this still relevant?

@chalin
Copy link
Collaborator Author

chalin commented Apr 13, 2023

@eugeneo - yes it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docsy e0-minutes Effort: < 60 min style Front-end site design / styling upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eugeneo @chalin