Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👯 Contributing guide? #2

Open
LucyMcGowan opened this issue Sep 13, 2017 · 1 comment
Open

👯 Contributing guide? #2

LucyMcGowan opened this issue Sep 13, 2017 · 1 comment

Comments

@LucyMcGowan
Copy link

LucyMcGowan commented Sep 13, 2017

Disclaimer: This has 💯% selfish motives, because I think this is wicked cool 😎 and want to contribute, if you'll have me.

Would you be interested in putting together a contributing guide? I would love to contribute to this, but I'm not sure where you are seeking contributions.

  • Here is an example of a guide 👸 Jenny Bryan wrote for googledrive.
  • Alternatively, it could be something quite simple like a list of things you hope contributors could add, like in the meetupr readme.
@gsimchoni
Copy link
Owner

I wonder if Jenny Bryan knows she has her own emoji!

Giving the amount of time I have these days, I think I will add a list of things. Everyone is welcome to contribute, of course. The main issues are, from the top of my head, are:

  1. Major refactoring to the initializeGame function, putting many repeating clauses in their own functions and possibly removing these functions to utils.R which is empty (I couldn't do it!)
  2. TEEEESSSTTING (I'm not that familiar with testing in R, and here it is a challenge because this is a maze, a process, we will never be able to cover all possible scenarios, so I would start with simple unit-tests of different functions)
  3. Separating ALL texts from game, so that the game would be completely configurable to be charged with another game or even translated to another language
  4. Answering issues such as the one you raised, need to be able to accept different answers, or here and there improve questions/hints/solutions (there are about 80 of them overall, and although I think I tested each and every one, the odds are against me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants