Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Menu to use Key instead of KeyCode #3053

Closed
tig opened this issue Dec 16, 2023 · 1 comment
Closed

Change Menu to use Key instead of KeyCode #3053

tig opened this issue Dec 16, 2023 · 1 comment

Comments

@tig
Copy link
Collaborator

tig commented Dec 16, 2023

With #2927, Key is now a high-level class that we should encourage developers to use vs. partying on KeyCode at a low level. All classes that have HotKeys or ShortCuts or other things that specify key strokes should use Key and not KeyCode or Rune or char.

Menu is a great example of this.

This is not super high priority though.

@tig
Copy link
Collaborator Author

tig commented Dec 17, 2023

Dupe of #2975.

@tig tig closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

No branches or pull requests

1 participant