Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks on modifying metrics #2

Open
guilhermelowa opened this issue Oct 10, 2020 · 0 comments
Open

Checks on modifying metrics #2

guilhermelowa opened this issue Oct 10, 2020 · 0 comments
Labels

Comments

@guilhermelowa
Copy link
Owner

Currently when we add / remove a metric, we update the file with the active metrics and update the header of the metrics.csv file (where the recordings are stored). I can see two problems with it: metrics with same name and adding a previously removed metric.

  • When adding a metric with the same name as an active one, we have to make sure to include only one.
  • When adding a metric previously removed, we shouldn't change the header on the metrics.csv file. Just keep writing to the respective column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant