Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs tests #37

Open
hannesveit opened this issue Mar 19, 2021 · 2 comments
Open

Needs tests #37

hannesveit opened this issue Mar 19, 2021 · 2 comments

Comments

@hannesveit
Copy link
Contributor

Since there are currently no tests, it's hard to judge whether a new contribution will introduce subtle bugs / break currently supported functionality. It's basically up to the developer and/or the reviewer to manually test the tool in all supported scenarios as best as they can.

I'm working on a test suite with some unit tests and functional tests, which authenticate the API and create new test groups / supergroups, send random messages to those groups, and then delete those messages, and finally clean up and delete the test groups.

This should make testing and reviewing changes much safer.

@hannesveit
Copy link
Contributor Author

One thing to think about... I’d like to confirm that the script doesn’t try to delete someone else’s messages, for instance. That can’t be tested in groups that we create during the tests, since those will only contain our own messages obviously.

Maybe post and delete a few messages in an existing public group? Are there appropriate “test groups” where people wouldn’t be offended by a bunch of random messages?

Or we could create one for this purpose...

@hannesveit
Copy link
Contributor Author

Ah, we can just invite a bot and make it to say something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant