Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest golang io package #1

Open
gedw99 opened this issue Feb 15, 2024 · 6 comments
Open

upgrade to latest golang io package #1

gedw99 opened this issue Feb 15, 2024 · 6 comments

Comments

@gedw99
Copy link

gedw99 commented Feb 15, 2024

Hey @guumaster

Nice tool and thank you for putting this out there.

Would you be open to adding multi path matching and perhaps upgrading to the latest golang io package ?

@gedw99 gedw99 changed the title upgrade ? upgrade to latest golang io package Feb 15, 2024
@guumaster
Copy link
Owner

@gedw99 thanks for testing this project. Happy to check PRs and merge.

@gedw99
Copy link
Author

gedw99 commented Feb 15, 2024

Will make a PR. Am working on steep deadline so will swing back to this

@gedw99
Copy link
Author

gedw99 commented Oct 11, 2024

hey @guumaster

forked over here: https://github.com/gedw99/dir-cleaner

upgraded everything.

now just working out how I can clean a nested folder structure where I need all the .bin, .dep folders to be deleted. There is a make target called "test" that creates this structure and attempts to clean it. If you could advise on that would be cool.

Its a structure I use for the EU Open Science Project, to allow mono repos style development:)

@gedw99
Copy link
Author

gedw99 commented Oct 11, 2024

I got the test working. works really well !! nice work @guumaster

Let me know what you want me to do with this.
NONE of your code has changed. I just did Spring Cleaning..

@gedw99 gedw99 closed this as completed Oct 11, 2024
@gedw99 gedw99 reopened this Oct 11, 2024
@gedw99
Copy link
Author

gedw99 commented Oct 11, 2024

OOOPS. I renamed the git org in the go mod namespace...

Can rename it back.. I forgot that your wanted a PR back, and just renamed it because its easier with go module madness sometimes.

@gedw99
Copy link
Author

gedw99 commented Oct 11, 2024

Its ready to be PR'edd back to you if you want it.

The test in windows fail. I suggest get it back into Origin and then we can have a look at whats happening in Windows. Main thing is that we have windows tests so we can see whats going on in CI.

https://github.com/gedw99/dir-cleaner/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants