Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review #2

Closed
3 of 4 tasks
kaat0 opened this issue Nov 18, 2024 · 9 comments
Closed
3 of 4 tasks

review #2

kaat0 opened this issue Nov 18, 2024 · 9 comments
Milestone

Comments

@kaat0
Copy link
Contributor

kaat0 commented Nov 18, 2024

recommended:

  • include other OSs in CI.yml for testing, for example:
      matrix:
        version:
          - 'lts' # latest LTS build
          - '1' # current
          - 'pre' # latest prerelease build (RCs, betas, and alphas
        julia-arch: [x64, x86, aarch64]
        os: [macOS-latest, ubuntu-latest, windows-latest]
        exclude:
          - os: macOS-latest
            julia-arch: x86
          - os: ubuntu-latest
            julia-arch: aarch64
          - os: windows-latest
            julia-arch: aarch64
  • provide description for the different use of query() and turbo_url()

If helpful:

  • Provide CRONTRIBUTION.md
  • use all-contributors bot
@gwehrle
Copy link
Owner

gwehrle commented Nov 18, 2024

Thanks a lot. I'll solve the recommended ones before release. As the other ones are not blocking a release I'll work on them afterwards.

@gwehrle
Copy link
Owner

gwehrle commented Nov 21, 2024

@kaat0 Do you think the difference between query and turbo_url is clear now?

@kaat0
Copy link
Contributor Author

kaat0 commented Nov 21, 2024

Definitely.
What is your thought on automatically opening a browser with the provided query instead of printing it to the terminal? E.g. https://stackoverflow.com/questions/75475602/julia-how-to-open-a-url-into-browser

@gwehrle
Copy link
Owner

gwehrle commented Nov 22, 2024

Would be pretty nice. I think I would prefer to have both options. With and without opening the browser. I tend to use a separate function like open_turbo_url(). The functionality is so different that a parameter feels a bit odd, but would also work.

I hope Desktop.jl works fine. It would be a little bit overpowered using LiveServer.jl for just this tiny feature.

@gwehrle gwehrle added this to the v0.0.2 milestone Nov 22, 2024
@gwehrle
Copy link
Owner

gwehrle commented Nov 22, 2024

@all-contributors please add @kaat0 for ideas and userTesting

Copy link
Contributor

@gwehrle

I've put up a pull request to add @kaat0! 🎉

@gwehrle
Copy link
Owner

gwehrle commented Nov 22, 2024

Would be pretty nice. I think I would prefer to have both options. With and without opening the browser. I tend to use a separate function like open_turbo_url(). The functionality is so different that a parameter feels a bit odd, but would also work.

I hope Desktop.jl works fine. It would be a little bit overpowered using LiveServer.jl for just this tiny feature.

I'll transfer this discussion i a new Issue, so this can be closed.

@kaat0
Copy link
Contributor Author

kaat0 commented Nov 23, 2024

@all-contributors please add @gwehrle for ideas and userTesting and code

Copy link
Contributor

@kaat0

I've put up a pull request to add @gwehrle! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants