Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce @testset "query" #5

Closed
kaat0 opened this issue Nov 19, 2024 · 1 comment
Closed

Reduce @testset "query" #5

kaat0 opened this issue Nov 19, 2024 · 1 comment

Comments

@kaat0
Copy link
Contributor

kaat0 commented Nov 19, 2024

I would suggest that you make the query smaller and easier to debug.

For example by reducing the bounding box of the query:

[out:json];
	node[amenity=drinking_water]
    (48.207304432634,16.370830535889,48.210403906279,16.375411748886);
out;
gwehrle added a commit that referenced this issue Nov 21, 2024
@gwehrle
Rewrite Tests
0d375fe 
- restrict bbox to have only one result as it is easier to debug (see #5)
- unify tests and documentation ( filenames, out format, …)
-  do not test server response as this might change
@gwehrle
Copy link
Owner

gwehrle commented Nov 21, 2024

Good suggestion! I changed this in the commit referenced above.

@gwehrle gwehrle closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaat0 @gwehrle