Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define command to support vim-like operators #59

Closed
haberdashPI opened this issue Feb 11, 2025 · 3 comments · Fixed by #62
Closed

Define command to support vim-like operators #59

haberdashPI opened this issue Feb 11, 2025 · 3 comments · Fixed by #62

Comments

@haberdashPI
Copy link
Owner

haberdashPI commented Feb 11, 2025 •
edited
Loading

The key functionality I need here is:

  • master-key.storeCommand will store a command object in a named register
  • master-key.executeStoredCommand will execute the command stored in a given, named register, possibly adding additional arguments to the command
@haberdashPI
Copy link
Owner Author

@bhainesva, based on the list you made in #42, I think this is the highest priority change to facilitate vim-like keybinding sets. Does that sound reasonable to you based on your experience trying to implement this?

@haberdashPI haberdashPI mentioned this issue Feb 14, 2025
Merged
@bhainesva
Copy link
Contributor

I see it's already implemented 🥳 but yes I think that's accurate.

@haberdashPI
Copy link
Owner Author

I see it's already implemented 🥳 but yes I think that's accurate.

Thanks for confirming! Yes, it's close; still have some tests to puzzle through, but I think that is mostly about the flakiness of UX testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement storeCommand and executeStoredCommand haberdashPI/vscode-master-key
2 participants
@bhainesva @haberdashPI