Pre-commit mdformat hook conflict #464
Labels
complexity: small
Small changes with all steps laid out in detail; new member can complete in <1.5 hours
feature: build
good first issue
Good for newcomers
role: dev
s: PD team
stakeholder: People Depot Team
size: 0.25pt
Can be done in 1.5 hours or less
Milestone
Overview
The automated pre-commit checks in GitHub shows the code is broken. This is because pre-commit.ci is running a newer version of
mdformat-mkdocs
than our developer local systems, which is why we don't see the error.In the newer version,
mdformat-mkdocs
andmdformat-admon
are both trying to format admonitions, and we should dropmdformat-admin
sincemdformat-mkdocs
does it better.Action Items
.pre-commit-config.yaml
to removemdformat-admon
and set a minimum version onmdformat-mkdocs
Resources/Instructions
The error: Recent commits to main where the ones in Feb 3 have red x marks for failing pre-commit
Why don't developer see the error locally? Individual developers may not see this error if they have an older version of
mdformat-mkdocs
hook installed. The way to update ispre-commit clean
followed bypre-commit run
. Setting the minimum version will cause the developer pre-commit install to update to the new version.Why choose
mdformat-mkdocs
overmdformat-admon
? from mdformat-mkdocs readmeThe text was updated successfully, but these errors were encountered: