Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize #25

Open
dillonstreator opened this issue Jul 30, 2022 · 2 comments · May be fixed by #26
Open

Memoize #25

dillonstreator opened this issue Jul 30, 2022 · 2 comments · May be fixed by #26

Comments

@dillonstreator
Copy link

use-mobile-detect-hook/src/index.ts

Line 22 in 096f94e

return getMobileDetect(userAgent);

@haldarmahesh
Copy link
Owner

hey @dillonstreator can you please add more description on this issue?

@dillonstreator
Copy link
Author

functions are being returned from useMobileDetect which presumably are being run on every render when the results could be memoized since user agent doesn't really change

@dillonstreator dillonstreator linked a pull request Jul 30, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add caching, change API, update major version dillonstreator/use-mobile-detect-hook
2 participants
@haldarmahesh @dillonstreator