Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Specify font family in settings #67

Open
tonyrobots opened this issue Feb 7, 2024 · 4 comments
Open

Feature Request: Specify font family in settings #67

tonyrobots opened this issue Feb 7, 2024 · 4 comments

Comments

@tonyrobots
Copy link

Hi, would be great to be able to specify the font family for details in the sonos_settings.py file. I might take a swing at this myself, but wanted to post in case there's any direction or gotchas worth knowing about. Looks like some of the infrastructure to support this was put in place but just never completed.

Thanks!

@ashenshugarRET
Copy link
Contributor

I did some work on the overlay feature to show artist and track names, a big gotcha of being able to choose the font is that most fonts have letters of different widths making predicting how the text will fit on the screen almost impossible. In the end, I went for the monospaced font Consolas as I liked the look of it and it behaved predictably when calculating the length of the text strings for resizing etc...

@ashenshugarRET
Copy link
Contributor

I have a working version of this functionality on my repository forked from this one, I'm going to test it for a few days so I can be sure it isn't doing anything unexpected and if all goes well I'll raise a pull request to incorporate it into this repository.

@tonyrobots
Copy link
Author

Right, that makes sense. I see there's some hardcoded bits in there like if str_length > 26, use font_size = 14, else use font_size = 18, and that sort of thing, which can be tricky with a variable width font. But still it would be good to give users the option, I think. If you don't mind sharing your forked repo I'd love to give it a spin.

@ashenshugarRET
Copy link
Contributor

Hello no problem my repository is here https://github.com/ashenshugarRET/music-screen-api.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants