Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any usages of RequestPartition.isDefaultPartition() are bugs waiting to happen #6703

Open
tadgh opened this issue Feb 12, 2025 · 0 comments
Open

Comments

@tadgh
Copy link
Collaborator

tadgh commented Feb 12, 2025

Usages of this deprecated method will break on any installations that modify the default partition ID from being NULL to being anything else. Need to sweep through and remove all usages, and replace them with usages of the IRequestPartitionHelperSvc, or some other equivalent API. May be worth revisiting our scattered API for default/all partitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant