Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix value type of pox-maxconn annotation from integer to string #688

Open
FabioDavidF opened this issue Dec 26, 2024 · 4 comments
Open
Assignees
Labels
waiting-for-feedback waiting for feedback

Comments

@FabioDavidF
Copy link

The problem:

The example usage of the pod-maxconn service annotation uses an integer value, while annotations require string values.

Since Annotations in kubernetes must have string values, I think the example should be a string aswell
image

The solution:

I don't have permission to push a new branch in order to open a PR, but it would be a 1 liner:
image

@hdurand0710 hdurand0710 self-assigned this Jan 7, 2025
@hdurand0710
Copy link
Contributor

Hi @FabioDavidF
Thanks for reporting it.
Im fixing this.
annotations.md is generated, the change has to be done on doc.yaml but as you say it's a 1 liner.

@FabioDavidF
Copy link
Author

Thanks for the follow-up @hdurand0710.

Quick question: Is haproxy still accepting open contributions to this project?

@hdurand0710
Copy link
Contributor

@FabioDavidF
Sure, contributions are very welcome.

@hdurand0710
Copy link
Contributor

@FabioDavidF
This is fixed with commit 'ce2bb5056469377ebfa421bae574f880a11700e0`

@hdurand0710 hdurand0710 added the waiting-for-feedback waiting for feedback label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-feedback waiting for feedback
Projects
None yet
Development

No branches or pull requests

2 participants