Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR conversation and PR changes feedback (2&3) #707

Open
foalsboy opened this issue Jan 17, 2025 · 0 comments
Open

PR conversation and PR changes feedback (2&3) #707

foalsboy opened this issue Jan 17, 2025 · 0 comments
Assignees
Labels
design Requires design team involvement Pixel Point Responsibility of Pixel Point team

Comments

@foalsboy
Copy link
Collaborator

foalsboy commented Jan 17, 2025

PR conversation page

Image

  1. there should be a resolve conversation button here along with reply section https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=17807-80466#1082819455
  2. what should a suggestion added look like? it should also have 2 buttons - “add suggestion to batch” , “commit suggestion” https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=17807-80466#1082819455
  3. should commit messages also show the sha and be copyable? https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=7682-24837#932464423
  4. there should be a commit suggestion button at the top along with the count of suggestions in batch https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=17807-80466#1084336529
  5. when its just a single comment, is the ellipses out of the comment box in comparison to the the comment thread? https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=21924-152933#1076321424
  6. Finalize modal for attaching file from the comment
  7. was the edit pr title for now Harness team just made it similiar to gitness for the flow (screenshot 1 and 2)

Image

Image

  1. another one is how to add a description if its not there from the start, (screenshot 3+4), we show the activity of the created pr but if no description is there it isnt shown

Image

Image

  1. also another feature that is not specific to pr pages and we wont initially do this is ,  we had tooltip that showed time  was when you hovered over any piece(screenshot 5) (any time we hover over a time (relative or otherwise) it would be great to show a time card similar to this: https://vercel.com/geist/relative-time-card)

Image

  1. we also seemed to have lost the attach image or drop image text in pr comment box to show that we support this feature

Image

  1. We should also discuss where to surface errors on pr page (TBD)

PR Changes page

Image

  1. is this file structure supposed to be shown on the left, its not present in the designs on the left/right https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=17479-84539#1084046575
  2. there should be an icon somewhere here to expand/collapse all lines of code https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=17479-84539#1084048225
  3. there should be a commit suggestions batch button on top https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=17479-84539#1084339569
  4. what should a comment thread look like here? also there should be an ellipsis on the right - delete / copy link to comment etc? https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd?node-id=17479-84539#1074117351
@foalsboy foalsboy added design Requires design team involvement Pixel Point Responsibility of Pixel Point team labels Jan 17, 2025
@foalsboy foalsboy self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Requires design team involvement Pixel Point Responsibility of Pixel Point team
Projects
None yet
Development

No branches or pull requests

1 participant