Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few feedback points #2

Closed
ZeliTheZealot opened this issue Jan 1, 2021 · 2 comments
Closed

A few feedback points #2

ZeliTheZealot opened this issue Jan 1, 2021 · 2 comments

Comments

@ZeliTheZealot
Copy link

ZeliTheZealot commented Jan 1, 2021

First of all -- well done! Much better than the Solarized theme I think. However, there are some feedback from me. I will update this as I go along.

  1. Please offer the option of Dark Gray background instead of Black
  2. There is low contrast between background and the keywords \begin, \section, \subsection, \end.
  3. Commands within math environments are harder to see (their arguments are fine). For example, in \mathbb{N}, the dark blue of \mathbb is harder to see than the light mint {N}.
  4. The argument of \label is hard to see if they're duplicated in multiple figures, for example the asdf in label{asdf}, if two figures have this same label.
@hasecilu
Copy link
Owner

hasecilu commented Jan 15, 2021

Thanks for your feedback.

    • Done.
    • Yeah, seeing it in detail is slightly difficult to see. Maybe a lighter blue will work.
    • Generally I have no problem seeing it but when the line is selected is harder to see the commands, I don't know whether to change the command color or the line-highlight color.
    • I am aware of it, maybe a light purple color will work.

Any color suggestion will be appreciated.
I hope to fix it soon.

@hasecilu hasecilu pinned this issue Jan 22, 2021
@hasecilu
Copy link
Owner

7 months later I can say:

  1. Done.
  2. Done. I changed to a lighter blue. I think it's ok but need feedback.
  3. Done. I didn't change the command color but changed the line highlight color to gray.
  4. Done. I changed to a lighter purple.

@hasecilu hasecilu closed this as completed Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants