Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-1056 Use BlockHeader.first_transaction_consensus_time as consensusStart/consensusEnd #10073

Open
Tracked by #8834
xin-hedera opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement Type: New feature importer Area: Importer

Comments

@xin-hedera
Copy link
Collaborator

Problem

In a block stream file, BlockHeader.first_transaction_consensus_time should be used to set BlockFile.consensusStart and optionally BlockFile.consensusEnd. This is especially important for block stream files without any event transactions, or the extreme case, without rounds at all.

The field used to be left as null due to consensus nodes bug, once we get a good sample block stream file, we should add the support.

Solution

  • read BlockHeader.first_transaction_consensus_time, and set it to BlockFile.consensusStart and BlockFile.consensusEnd

Alternatives

No response

@xin-hedera xin-hedera added enhancement Type: New feature importer Area: Importer labels Jan 9, 2025
@xin-hedera xin-hedera changed the title HIP-1056 Use BlockHeader.first_transaction_consensus_time as BlockFile's consensusStart/consensusEnd HIP-1056 Use BlockHeader.first_transaction_consensus_time as consensusStart/consensusEnd Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature importer Area: Importer
Projects
None yet
Development

No branches or pull requests

1 participant