fix #20409 - Check definitions not reflected in output from agent/health/service/id/:service-id

[vijayraghav-io]

Fixes #20409

Testing & Reproduction steps

Refer #20409

PR Checklist

• updated test coverage
• external facing docs updated
• appropriate backport labels added
• not a security concern

[vijayraghav-io]

As an update, even after populating the HealthCheckDefinition, the expected values are not shown in api output.
Apart from the changes done so far in func agentHealthService, there needs some more update to fix the issue, so checking the service registration code. Will update once the fix is complete.

[vijayraghav-io]

The fix is almost done!
For some reason the "Definition" field was left out while creating "check" before adding to the local "state" in

consul/agent/agent.go

Line 2626 in c82b78b

EnterpriseMeta: service.EnterpriseMeta,

Added three fields and verified, its working as expected now!.
Need to add all other fields (like HTTP, TCP,...). Will check the logic thoroughly again and update.

[vijayraghav-io]

The fix is done , added a test case.
This PR can be reviewed

[vijayraghav-io]

Hi @jkirschner-hashicorp / @huikang / @david-yu ,
Kindly review this PR.

[vijayraghav-io]

Hi @david-yu,
Requesting you to review this PR.

[github-actions]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[vijayraghav-io]

Requesting to review this PR

[github-actions]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[vijayraghav-io]

Reminding for PR review

[github-actions]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[github-actions]

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.