-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add base64gzip function support to Packer template #13142
[Feature] Add base64gzip function support to Packer template #13142
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
e19e954
to
3198acd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pwfee,
Thanks for the PR, this LGTM! I left a small nit on a comment, but that's minor, I'll let you address that, and I'll come back for a final pass of review after.
Pre-approving to not block later.
Thanks for the update @pwfee, merging once tests go green |
Only test failing is the Vercel deployment, which is irrelevant to this PR, so merging now. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Why
Packer doesn't support
base64zip()
which is a useful function to compress user_data or any string in Packer. However terraform indeed supports this function.As one of the many usecases, AWS has limit the EC2 user_data size on 16KB. It's easier to over this size and we are willing to have this compress function.
Changes
Tests