Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slice init length #13175

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

huochexizhan
Copy link
Contributor

The intention here should be to initialize a slice with a capacity of len(repeatMap) rather than initializing the length of this slice.

@huochexizhan huochexizhan requested a review from a team as a code owner October 1, 2024 15:43
Copy link

hashicorp-cla-app bot commented Oct 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @huochexizhan, this LGTM, good catch!

Will run tests now and merge if green

@lbajolet-hashicorp
Copy link
Contributor

Only test failing is Vercel, not a concern for this change, merging now.

@lbajolet-hashicorp lbajolet-hashicorp merged commit 6e417bb into hashicorp:main Oct 29, 2024
10 of 11 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants