Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hcp_sbom provisioner reference #13262

Closed
wants to merge 3 commits into from

Conversation

BrianMMcClain
Copy link
Contributor

  • Add hcp_sbom reference
  • Update provisioner overview page

ritsok
ritsok previously approved these changes Jan 21, 2025
website/content/docs/provisioners/hcp_sbom.mdx Outdated Show resolved Hide resolved
@lbajolet-hashicorp
Copy link
Contributor

Hey @BrianMMcClain,

I've seen this one pop this morning but am only commenting now (sorry), just to let you know, the documentation for this feature is baked into the PR that introduces the code for the feature (in a separate branch, refer to PR #13171, which is still marked as [POC], but is very much not anymore so).
Regarding those documentation changes, would it be possible to amend this PR instead?

@BrianMMcClain BrianMMcClain changed the base branch from main to poc/provisioner-hcp-sbom January 21, 2025 16:05
@BrianMMcClain BrianMMcClain marked this pull request as draft January 21, 2025 16:05
@BrianMMcClain
Copy link
Contributor Author

Hey @BrianMMcClain,

I've seen this one pop this morning but am only commenting now (sorry), just to let you know, the documentation for this feature is baked into the PR that introduces the code for the feature (in a separate branch, refer to PR #13171, which is still marked as [POC], but is very much not anymore so). Regarding those documentation changes, would it be possible to amend this PR instead?

@lbajolet-hashicorp Ah good call, totally missed there were docs included in that draft, my bad! Closing this one and drafting a new PR against that branch now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants