Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add graceful error handling in get-version-matrix.yaml #1586

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add graceful error handling in get-version-matrix.yaml #1586

wants to merge 4 commits into from
+18 −4

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Feb 7, 2025

Description

image

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner February 7, 2025 21:33
@BBBmau BBBmau requested a review from jrhouston February 7, 2025 21:34
@BBBmau
Copy link
Contributor Author

BBBmau commented Feb 7, 2025

this error was just a connection issue where jq tries to get .ref which is in the JSON that we get from curl

@BBBmau BBBmau added the CI label Feb 7, 2025
@BBBmau
Copy link
Contributor Author

BBBmau commented Feb 7, 2025

image

adds a failure when we don't get a successful response from the curl command.

@BBBmau
Copy link
Contributor Author

BBBmau commented Feb 7, 2025

fails more gracefully now:

image

@BBBmau BBBmau changed the title remove fromJson from tests.yaml add graceful error handling in get-version-matrix.yaml Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhouston jrhouston Awaiting requested review from jrhouston

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CI pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BBBmau