Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write-only attribute "set_wo" #1592

Merged
merged 10 commits into from
Feb 25, 2025
Merged

Add write-only attribute "set_wo" #1592

merged 10 commits into from
Feb 25, 2025

Conversation

jrhouston
Copy link
Contributor

Description

This PR adds a write-only version of the set attribute called set_wo. An revision attribute set_wo_revision is also added for triggering updates to the write only attribute.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
❯ TF_ACC_TERRAFORM_VERSION=v1.11.0-rc1 TF_ACC=1 KUBE_CONFIG_PATH="$HOME/.kube/config" make testacc TESTARGS="-count=1 -run TestAccResourceRelease_set_wo"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test "./helm" -v -count=1 -run TestAccResourceRelease_set_wo -timeout 10m
2025/02/24 21:41:23 Created repository package for "broken-chart"
2025/02/24 21:41:24 Created repository package for "crds-chart"
2025/02/24 21:41:24 Created repository package for "dependency-bar"
2025/02/24 21:41:24 Created repository package for "dependency-foo"
2025/02/24 21:41:24 Created repository package for "failed-deploy"
2025/02/24 21:41:25 Created repository package for "kube-version"
2025/02/24 21:41:25 Created repository package for "test-chart"
2025/02/24 21:41:25 Created repository package for "test-chart-v2"
2025/02/24 21:41:26 Created repository package for "umbrella-chart"
2025/02/24 21:41:26 Built chart repository index
=== RUN   TestAccResourceRelease_set_wo
--- PASS: TestAccResourceRelease_set_wo (9.64s)
PASS
ok      github.com/hashicorp/terraform-provider-helm/helm       13.364s

Release Note

Release note for CHANGELOG:

Add write only attribute "set_wo"

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jrhouston jrhouston requested a review from a team as a code owner February 25, 2025 04:42
func TestAccResourceRelease_emptyVersion(t *testing.T) {
name := randName("basic")
namespace := createRandomNamespace(t)
defer deleteNamespace(t, namespace)

resourceName := "helm_release.test"
resource.Test(t, resource.TestCase{
//PreCheck: func() { testAccPreCheck(t) },
// PreCheck: func() { testAccPreCheck(t) },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove all these comments leftover from the migration in another PR – this is just formatter noise.

@jrhouston jrhouston merged commit 12c1c89 into main Feb 25, 2025
17 checks passed
@jrhouston jrhouston deleted the writeonly-attrs branch February 25, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants