-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add write-only attribute "set_wo" #1592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0df3a3
to
bbf1095
Compare
abb1ed0
to
0afef79
Compare
arybolovlev
approved these changes
Feb 25, 2025
jrhouston
commented
Feb 25, 2025
func TestAccResourceRelease_emptyVersion(t *testing.T) { | ||
name := randName("basic") | ||
namespace := createRandomNamespace(t) | ||
defer deleteNamespace(t, namespace) | ||
|
||
resourceName := "helm_release.test" | ||
resource.Test(t, resource.TestCase{ | ||
//PreCheck: func() { testAccPreCheck(t) }, | ||
// PreCheck: func() { testAccPreCheck(t) }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove all these comments leftover from the migration in another PR – this is just formatter noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a write-only version of the
set
attribute calledset_wo
. An revision attributeset_wo_revision
is also added for triggering updates to the write only attribute.Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note