Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: add trafficDistribution field in service.spec #2581

Open
BBBmau opened this issue Sep 3, 2024 · 4 comments
Open

services: add trafficDistribution field in service.spec #2581

BBBmau opened this issue Sep 3, 2024 · 4 comments

Comments

@BBBmau
Copy link
Contributor

BBBmau commented Sep 3, 2024

Description

v1.31 graduated trafficDistributions field from alpha to beta with the feature gate being set to enabled by default.

k8s PR: kubernetes/enhancements#4444
Service Documentation: https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution

The API docs mentions that this is in alpha, this is wrong and an issue has been raised on the k8s website repo: kubernetes/website#47776

changes would needed to be applied with structure_service_spec.go:

func flattenServiceSpec(in v1.ServiceSpec) []interface{} {
att := make(map[string]interface{})
if len(in.Ports) > 0 {
att["port"] = flattenServicePort(in.Ports)
}
if len(in.Selector) > 0 {
att["selector"] = in.Selector
}
if in.ClusterIP != "" {
att["cluster_ip"] = in.ClusterIP
}
if len(in.ClusterIPs) > 0 {
att["cluster_ips"] = in.ClusterIPs
}

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@aayushsss1
Copy link
Contributor

@BBBmau I can take this up if no one's currently working on it!

@BBBmau
Copy link
Contributor Author

BBBmau commented Oct 8, 2024

@aayushsss1 this would be good to pick up, however this also would fall under blocked since it can only be merged once we've addressed the k8s version bump in the next major release of the provider.

You are welcome to work on it if still interested!

@BBBmau BBBmau added the blocked label Oct 8, 2024
@BBBmau BBBmau added this to the v3.0.0 milestone Oct 8, 2024
@aayushsss1
Copy link
Contributor

Okay sure, I'll have a look into it!

@JaylonmcShan03
Copy link
Contributor

@BBBmau I'll glance over this issue next week and if it's not tackled I don't mind tackling this for Q4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants