Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: vault_pki_secret_backend_config_acme lack of max_ttl option #2410

Open
Bartosz-lab opened this issue Feb 23, 2025 · 1 comment · May be fixed by #2411
Open

[Enhancement]: vault_pki_secret_backend_config_acme lack of max_ttl option #2410

Bartosz-lab opened this issue Feb 23, 2025 · 1 comment · May be fixed by #2411
Labels
enhancement pki pki-enhancements

Comments

@Bartosz-lab
Copy link

Bartosz-lab commented Feb 23, 2025 •
edited
Loading

Description

Resource vault_pki_secret_backend_config_acme don't contain's max_ttl option. So I suggest to add it :D

Affected Resource(s) and/or Data Source(s)

  • vault_pki_secret_backend_config_acme

Potential Terraform Configuration



References


https://developer.hashicorp.com/vault/api-docs/secret/pki/issuance#max_ttl


Would you like to implement a fix?


Yes

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            


  


  
    
  
  

    
  Bartosz-lab 

      added a commit
        to Bartosz-lab/terraform-provider-vault
      that referenced
      this issue

    
      Feb 23, 2025
    
    

      


  

    

      


  

      
        @Bartosz-lab
  





      

        
          hashicorp#2410: add max_ttl to pki acme config
        


      


      

          

    
    
    

  

    


      


      

      


      
      

        
          f2cdae4
        
      

    

  




    

  




  


  
    
  
  

    
  Bartosz-lab 

      added a commit
        to Bartosz-lab/terraform-provider-vault
      that referenced
      this issue

    
      Feb 23, 2025
    
    

      


  

    

      


  

      
        @Bartosz-lab
  





      

        
          hashicorp#2410: add max_ttl to pki acme config
        


      


      

          

    
    
    

  

    


      


      

      


      
      

        
          3dd76c1
        
      

    

  




    

  




  

  

    
  


  

      

    @Bartosz-lab
Bartosz-lab



    linked a pull request
    
      Feb 23, 2025
    

    that will
    close
    this issue





  


  

      
   Open

  





  
  

      
        
      
      

  
    
    
  


    2 tasks
  





  









      

  
      



  

  @Bartosz-lab





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  Author


  


  

    

  





      


        


  
    

      
          
Created PR for that: #2411

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            


  


  
    
  
  

    
  Bartosz-lab 

      added a commit
        to Bartosz-lab/terraform-provider-vault
      that referenced
      this issue

    
      Feb 24, 2025
    
    

      


  

    

      


  

      
        @Bartosz-lab
  





      

        
          hashicorp#2410: add max_ttl to pki acme config
        


      


      

          

    
    
    

  

    


      


      

      


      
      

        
          4359368
        
      

    

  




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                    




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    enhancement

  

    pki

  

    pki-enhancements









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          
  

    

      

        
          

            
    

    Development
  




              
  
Successfully merging a pull request may close this issue.





    


  
          
      add to vault_pki_secret_backend_config_acme max_ttl option

    
      Bartosz-lab/terraform-provider-vault
    





        
      

    

  


      

    

  
      

  

    

      2 participants
    

    

        
          @stevendpclark 
        
          @Bartosz-lab