Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS storage backend docs do NOT mention that per default (including the example in the docs) the sdk connects via http instead of https #29304

Open
wenzel-felix opened this issue Jan 7, 2025 · 1 comment
Labels

Comments

@wenzel-felix
Copy link

Describe the bug
The official docs of the Vault OSS backend do NOT state that the default/example endpoint configuration does use HTTP instead of HTTPS, which could lead users to misconfigure their instances.

To Reproduce
Vault implementation:

client, err := oss.New(endpoint, accessKeyID, accessKeySecret, options)

OSS SDK:
https://github.com/aliyun/aliyun-oss-go-sdk/blob/b6e0a2ae5b13f20fcdaf8e5c00b0bcf9dece0a34/oss/conn.go#L886C1-L895C3

Expected behavior
The docs should include this essential information.

Environment:

Vault server configuration file(s):

Additional context

@wenzel-felix
Copy link
Author

Fix: #29305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants