Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/mssql: set default root rotation stmt for contained db #29399

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Jan 23, 2025

Description

There is an undocumented behavior with Contained DBs like AzureSQL. If you set contained_db to True then you must set a custom root_rotation_statements. This PR ensures we set a default root rotation statement for contained dbs.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@fairclothjm fairclothjm added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Jan 23, 2025
@fairclothjm fairclothjm added this to the 1.18.4 milestone Jan 23, 2025
@fairclothjm fairclothjm requested review from a team as code owners January 23, 2025 19:42
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 23, 2025
@fairclothjm fairclothjm requested a review from a team as a code owner January 23, 2025 19:45
@fairclothjm fairclothjm requested a review from paymanblu January 23, 2025 19:45
Copy link

github-actions bot commented Jan 23, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jan 23, 2025

Build Results:
All builds succeeded! ✅

vinay-gopalan
vinay-gopalan previously approved these changes Jan 23, 2025
@fairclothjm fairclothjm merged commit 04e7537 into main Jan 24, 2025
91 of 93 checks passed
@fairclothjm fairclothjm deleted the VAULT-32274/mssql/contained-db-fix branch January 24, 2025 20:42
@fairclothjm fairclothjm added backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent and removed backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants