Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: SeperateAttribs -> SeparateAttribs #77

Closed
kranich opened this issue May 19, 2015 · 4 comments
Closed

Fix typo: SeperateAttribs -> SeparateAttribs #77

kranich opened this issue May 19, 2015 · 4 comments

Comments

@kranich
Copy link
Contributor

kranich commented May 19, 2015

I submitted a pull request #76 to that end.

@svenpanne
Copy link
Member

To make the transition a bit smoother and avoid a major version bump, can we please keep the old SeperateAttribs constructor, too? Just add the correctly spelled constructor and a deprecation pragma like:

{-# DEPRECATED SeperateAttribs "Use 'SeparateAttribs' instead." #-}

After a few releases I'll remove the old constructor and bump the major version then. GLUT had a similar issue, BTW: haskell-opengl/GLUT@3e4baea

@kranich
Copy link
Contributor Author

kranich commented May 19, 2015

OK, just implemented your suggestions.

@kranich
Copy link
Contributor Author

kranich commented May 19, 2015

Build passed. You can merge pull request #76.

@svenpanne
Copy link
Member

Done. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants