Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of 'CustomMethod' #592

Open
michaelpj opened this issue Jun 21, 2024 · 0 comments
Open

Get rid of 'CustomMethod' #592

michaelpj opened this issue Jun 21, 2024 · 0 comments

Comments

@michaelpj
Copy link
Collaborator

CustomMethod is a bit of a hack to squeeze in an open set of additional methods into our otherwise closed set of methods. It adds a lot of difficulty for this reason: it's not typed in the same way, it can be used as anything, and it generally prevents us from doing anything that relies on knowing all the methods.

I think it would be better to rather also expose an untyped interface to the JSONRPC server. That is, be able to say something like:

addRequestHandler SMethod_TextDocumentCompletion $ \typedParams -> ...
Untyped.addRequestHandler "myMethod" $ \untypedParams -> ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant