Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regex-posix -> regex-tdfa #47

Open
phadej opened this issue Sep 6, 2019 · 2 comments
Open

Change regex-posix -> regex-tdfa #47

phadej opened this issue Sep 6, 2019 · 2 comments

Comments

@phadej
Copy link

phadej commented Sep 6, 2019

regex-posix is just broken (on Windows), that's what I heard from @RyanGlScott

@RyanGlScott
Copy link
Member

Don't just take it from me! The Cabal developers have also struggled with regex-posix, and this Cabal issue is where I first heard it from.

Another benefit of using regex-tdfa is that it's more GHCJS-compatible due to its lack of C dependencies. Of course, that's just a perk—not working correctly at all on Windows is arguably a more serious issue.

@hvr
Copy link
Member

hvr commented Sep 8, 2019

I briefly discussed this with Ryan; since regex-tdfa has issues of its own so that it doesn't qualify as a strictly better replacement for regex-posix, and I've coincidentally started the take-over process for the regex-posix package motivated by this and other packages I maintain (without being aware of this ticket), the plan is to fix the issues with regex-posix which occur on C-FFI capable platforms (and where regex-posix has clear benefits), as well as providing the ability to switch to regex-tdfa in test-framework for targets where regex-tdfa is a necessary evil; this plan should allow us to combine best-of-both-worlds approach, while addressing the concerns stated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants