-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS wants to install Stack #668
Comments
This popup was suggested by @wz1000 I was initially against it, because I find it questionable ergonomics. You can disable it easily, see https://github.com/haskell/vscode-haskell#setting-a-specific-toolchain Detecting whether a project uses stack or cabal is not as simple as it seems. We could parse |
Most projects don't use a hie.yaml, afaik, and ideally we shouldn't have to write it for the IDE to function as we intend. Maybe a global option to never install stack is an option? E.g., add a fourth button saying "No, never install Stack" |
I think more popups just make it worse. |
Absolutely, we already have too many pop-ups, I meant re-using this one, though. |
And then another button: "never install cabal"? 😅 |
In the same pop-up that currently asks you whether it should install cabal, yeah. Probably even for the ghc installation, since maybe people want to use stack provided ghc bindists. I am, as you may notice, also not convinced this is the best approach since we just have half a dozen of pop-ups... |
@hasufell but that is in a different Cabal popup, right? If clicking the That seems more ergonomic to me than discovering this Issue and through trial and error settling on: {
"haskell.toolchain": {
"stack": null
}
} (HLS docs recommendation gave me the Cabal popup for Previously I was using hardcoded PATH in options instead of GHCup, so apologies that I am late to the party. 😅 |
Only at a glance. Changing user configuration is hard. Do we just destructively overwrite? Prompt another time? No, I think the popups will have to go. It's not good UX. |
While you're at it, I'd really appreciate if you could disable the "no cradle found" popup, too. I'm brand-new to Haskell and all I wanted was to explore the language itself first, before learning about any more professional-level build tools. The proper AST-based syntax highlighting + the inferred type notations are really helpful for learning, so I'd still love to use this extension, but without any Cabal/Stack/Cradle expectations until I gradually opt in to each one. |
Every time I open (or reload) a project it asks me to install Stack. Not even asks, it informs me that it needs to.
Which isn't true, because I don't use Stack and when I say "no" then it works just fine.
For projects that don't use Stack, can this notification be not shown? Or, at least, has "No, don't ask again" button for parity?
It is a bit annoying because if I don't click "No" in time then the notification disappears, but HLS doesn't work for the project until I re-open it and click "No" in that notification popup.
Your environment
Which OS do you use:
MacOS
Steps to reproduce
Open any project that doesn't use Stack
Expected behaviour
Project opens, Stack isn't mentioned
Actual behaviour
The text was updated successfully, but these errors were encountered: