Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Header doesn't rerender after logout #62

Open
jt5301 opened this issue Jul 18, 2020 · 3 comments
Open

Bug: Header doesn't rerender after logout #62

jt5301 opened this issue Jul 18, 2020 · 3 comments

Comments

@jt5301
Copy link
Collaborator

jt5301 commented Jul 18, 2020

The search bar and settings button still show up when the user clicks logout

@grogsy
Copy link
Collaborator

grogsy commented Jul 18, 2020

When clicking logout, should I be redirecting the user instead of doing history.push('/login')?

@grogsy
Copy link
Collaborator

grogsy commented Jul 20, 2020

I've checked out this bug, and what I'm seeing happen is that on line 136 of Header.js {getUser() ? (... getUser() doesn't seem to get called, which suggests to me at least that the Header component isn't being rerendered after signing out

@grogsy
Copy link
Collaborator

grogsy commented Jul 20, 2020

Forgot to mention, the way I figured is by placing a console.log on the Header component right before rendering in an attempt to inspect the value returned by getUser(). It didn't get called iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants