Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Add healthcheck to container or to example #890

Open
2 of 3 tasks
GAS85 opened this issue May 4, 2024 · 1 comment · May be fixed by #893
Open
2 of 3 tasks

Add healthcheck to container or to example #890

GAS85 opened this issue May 4, 2024 · 1 comment · May be fixed by #893
Labels
accepted feature-request

Comments

@GAS85
Copy link

GAS85 commented May 4, 2024

What is the problem you are trying to solve with this feature?

It is good practice to add HEALTHCHECK to the container. Please add it to docker file or add example how to add it manually in e.g. docker-compose

What is the solution you are proposing?

No response

What alternatives have you considered?

No response

Additional context

No response

Contributions

  • I have searched through existing issues and feature requests to see if my idea has already been proposed.
  • If this feature is accepted, I would be willing to help implement and maintain this feature.
  • If this feature is accepted, I'm willing to sponsor the development of this feature.
@hay-kot
Copy link
Owner

hay-kot commented May 5, 2024

Happy to accept a PR on this one that doesn't add any new dependencies to the container.

GAS85 added a commit to GAS85/homebox that referenced this issue May 7, 2024
@GAS85
Add Docker Healthcheck to both containers.
387d52c 
Solution for hay-kot#890
Based on GoogleContainerTools/distroless#183 (comment)
@GAS85 GAS85 linked a pull request May 7, 2024 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Docker Healthcheck to both containers. GAS85/homebox
2 participants
@GAS85 @hay-kot