From 15ce5442c6236b37531be026d2ebf3e4412bc432 Mon Sep 17 00:00:00 2001
From: Alexander Platov <alexander.platov@hardcoreeng.com>
Date: Tue, 22 Oct 2024 10:46:39 +0300
Subject: [PATCH] Updated ListItem layout (#7008)

Signed-off-by: Alexander Platov <alexander.platov@hardcoreeng.com>
---
 .../components/calendar/DatePresenter.svelte  |  3 ++-
 .../calendar/DueDatePresenter.svelte          |  1 +
 .../src/components/LabelsPresenter.svelte     | 18 +++++++++++++++--
 .../components/ComponentEditor.svelte         |  9 +++++++--
 .../components/issues/DueDatePresenter.svelte |  1 +
 .../src/components/issues/IssueExtra.svelte   | 14 +++++++++----
 .../milestones/MilestoneEditor.svelte         |  8 ++++++--
 .../src/components/HyperlinkEditor.svelte     |  6 +++---
 .../src/components/list/ListItem.svelte       | 14 +++++++++++--
 .../src/components/list/ListPresenter.svelte  |  9 +++++++++
 .../presenters/GithubIssuePresenter.svelte    | 20 +++++++++----------
 11 files changed, 77 insertions(+), 26 deletions(-)

diff --git a/packages/ui/src/components/calendar/DatePresenter.svelte b/packages/ui/src/components/calendar/DatePresenter.svelte
index 595972441c..c041825c87 100644
--- a/packages/ui/src/components/calendar/DatePresenter.svelte
+++ b/packages/ui/src/components/calendar/DatePresenter.svelte
@@ -14,7 +14,7 @@
 -->
 <script lang="ts">
   import type { IntlString, Asset } from '@hcengineering/platform'
-  import { createEventDispatcher, ComponentType } from 'svelte'
+  import { createEventDispatcher, ComponentType, afterUpdate } from 'svelte'
 
   import { DateRangeMode } from '@hcengineering/core'
   import ui from '../../plugin'
@@ -86,6 +86,7 @@
       focusManager?.setFocus(idx)
     })
   }
+  afterUpdate(() => dispatch('resize', input?.clientWidth))
 </script>
 
 <button
diff --git a/packages/ui/src/components/calendar/DueDatePresenter.svelte b/packages/ui/src/components/calendar/DueDatePresenter.svelte
index a1b59f3e79..4190131e72 100644
--- a/packages/ui/src/components/calendar/DueDatePresenter.svelte
+++ b/packages/ui/src/components/calendar/DueDatePresenter.svelte
@@ -75,6 +75,7 @@
       {width}
       {shouldIgnoreOverdue}
       on:change={handleDueDateChanged}
+      on:resize
     />
   </div>
 {/if}
diff --git a/plugins/tags-resources/src/components/LabelsPresenter.svelte b/plugins/tags-resources/src/components/LabelsPresenter.svelte
index 3d98bb1ac7..dafe0c6185 100644
--- a/plugins/tags-resources/src/components/LabelsPresenter.svelte
+++ b/plugins/tags-resources/src/components/LabelsPresenter.svelte
@@ -49,18 +49,32 @@
 
   let allWidth: number
   const widths: number[] = []
+  const elements: HTMLDivElement[] = []
 
   afterUpdate(() => {
     let count: number = 0
     widths.forEach((i) => (count += i))
     full = count > allWidth
     dispatch('change', { full, ckeckFilled })
+    if (elements.length > 0) {
+      if (items.length > 4) dispatch('resize', elements[0]?.clientWidth)
+      else {
+        allWidth = 0
+        for (let i = 0; i < items.length; i++) {
+          if (elements[i].clientWidth !== undefined && allWidth < elements[i].clientWidth) {
+            allWidth = elements[i].clientWidth
+          }
+        }
+        dispatch('resize', allWidth + (items.length - 1) * 3)
+      }
+    }
   })
 </script>
 
 {#if kind === 'list' || kind === 'link'}
   {#if items.length > 4}
     <div
+      bind:this={elements[0]}
       class="label-box no-shrink"
       use:tooltip={{
         component: TagsItemPresenter,
@@ -70,8 +84,8 @@
       <TagsReferencePresenter {items} {kind} />
     </div>
   {:else}
-    {#each items as value}
-      <div class="label-box no-shrink" title={value.title}>
+    {#each items as value, i}
+      <div bind:this={elements[i]} class="label-box no-shrink" title={value.title}>
         <TagReferencePresenter attr={undefined} {value} {kind} />
       </div>
     {/each}
diff --git a/plugins/tracker-resources/src/components/components/ComponentEditor.svelte b/plugins/tracker-resources/src/components/components/ComponentEditor.svelte
index 58c0210f79..53d5cfc974 100644
--- a/plugins/tracker-resources/src/components/components/ComponentEditor.svelte
+++ b/plugins/tracker-resources/src/components/components/ComponentEditor.svelte
@@ -18,7 +18,7 @@
   import { RuleApplyResult, getClient, getDocRules } from '@hcengineering/presentation'
   import { Component, Issue, IssueTemplate, Project, TrackerEvents } from '@hcengineering/tracker'
   import { ButtonKind, ButtonShape, ButtonSize, deviceOptionsStore as deviceInfo } from '@hcengineering/ui'
-  import { createEventDispatcher } from 'svelte'
+  import { createEventDispatcher, afterUpdate } from 'svelte'
   import { Analytics } from '@hcengineering/analytics'
 
   import { activeComponent } from '../../issues'
@@ -47,6 +47,8 @@
 
   const dispatch = createEventDispatcher()
 
+  let element: HTMLDivElement
+
   const handleComponentIdChanged = async (newComponentId: Ref<Component> | null | undefined) => {
     if (!isEditable || newComponentId === undefined || (!Array.isArray(value) && value.component === newComponentId)) {
       return
@@ -101,11 +103,13 @@
       }
     }
   }
+
+  afterUpdate(() => dispatch('resize', element?.clientWidth))
 </script>
 
 {#if kind === 'list'}
   {#if !Array.isArray(value) && value.component}
-    <div class={compression ? 'label-wrapper' : 'clear-mins'}>
+    <div bind:this={element} class={compression ? 'label-wrapper' : 'clear-mins'}>
       <ComponentSelector
         {kind}
         {size}
@@ -127,6 +131,7 @@
   {/if}
 {:else}
   <div
+    bind:this={element}
     class="flex flex-wrap clear-mins"
     class:minus-margin={kind === 'list-header'}
     class:label-wrapper={compression}
diff --git a/plugins/tracker-resources/src/components/issues/DueDatePresenter.svelte b/plugins/tracker-resources/src/components/issues/DueDatePresenter.svelte
index 2f3f1131be..f0c1469370 100644
--- a/plugins/tracker-resources/src/components/issues/DueDatePresenter.svelte
+++ b/plugins/tracker-resources/src/components/issues/DueDatePresenter.svelte
@@ -55,4 +55,5 @@
   {size}
   {kind}
   shouldIgnoreOverdue={ignoreOverDue}
+  on:resize
 />
diff --git a/plugins/tracker-resources/src/components/issues/IssueExtra.svelte b/plugins/tracker-resources/src/components/issues/IssueExtra.svelte
index 8658ab1975..a9540f5208 100644
--- a/plugins/tracker-resources/src/components/issues/IssueExtra.svelte
+++ b/plugins/tracker-resources/src/components/issues/IssueExtra.svelte
@@ -13,6 +13,7 @@
 // limitations under the License.
 -->
 <script lang="ts">
+  import { createEventDispatcher, afterUpdate } from 'svelte'
   import { WithLookup } from '@hcengineering/core'
   import { getClient } from '@hcengineering/presentation'
   import type { Issue } from '@hcengineering/tracker'
@@ -26,13 +27,19 @@
   export let disabled: boolean = false
   export let maxWidth: string | undefined = undefined
 
+  let element: HTMLSpanElement
+  const dispatch = createEventDispatcher()
+
   $: presenters =
     value !== undefined ? getClient().getHierarchy().findMixinMixins(value, view.mixin.ObjectPresenter) : []
+
+  afterUpdate(() => dispatch('resize', element?.clientWidth))
 </script>
 
-{#if value}
+{#if value && presenters.length > 0}
   <span
-    class="presenter-label select-text p-1"
+    bind:this={element}
+    class="presenter-label select-text"
     class:with-margin={shouldUseMargin}
     class:list={kind === 'list'}
     style:max-width={maxWidth}
@@ -41,7 +48,7 @@
     {#if presenters.length > 0}
       <div class="flex-row-center">
         {#each presenters as mixinPresenter}
-          <Component is={mixinPresenter.presenter} props={{ value }} />
+          <Component is={mixinPresenter.presenter} props={{ value, kind }} />
         {/each}
       </div>
     {/if}
@@ -50,7 +57,6 @@
 
 <style lang="scss">
   .presenter-label {
-    overflow: hidden;
     display: inline-flex;
     align-items: center;
     flex-shrink: 1;
diff --git a/plugins/tracker-resources/src/components/milestones/MilestoneEditor.svelte b/plugins/tracker-resources/src/components/milestones/MilestoneEditor.svelte
index 5a190d829c..8d93e339e2 100644
--- a/plugins/tracker-resources/src/components/milestones/MilestoneEditor.svelte
+++ b/plugins/tracker-resources/src/components/milestones/MilestoneEditor.svelte
@@ -25,7 +25,7 @@
     DatePresenter,
     deviceOptionsStore as deviceInfo
   } from '@hcengineering/ui'
-  import { createEventDispatcher } from 'svelte'
+  import { createEventDispatcher, afterUpdate } from 'svelte'
   import { activeMilestone } from '../../issues'
   import tracker from '../../plugin'
   import MilestoneSelector from './MilestoneSelector.svelte'
@@ -51,6 +51,8 @@
   const client = getClient()
   const dispatch = createEventDispatcher()
 
+  let element: HTMLDivElement
+
   const handleMilestoneIdChanged = async (newMilestoneId: Ref<Milestone> | null | undefined) => {
     if (!isEditable || newMilestoneId === undefined || (!Array.isArray(value) && value.milestone === newMilestoneId)) {
       return
@@ -86,11 +88,12 @@
   $: _space = space ?? (!Array.isArray(value) ? value.space : { $in: Array.from(new Set(value.map((it) => it.space))) })
 
   $: twoRows = $deviceInfo.twoRows
+  afterUpdate(() => dispatch('resize', element?.clientWidth))
 </script>
 
 {#if kind === 'list'}
   {#if !Array.isArray(value) && value.milestone}
-    <div class={compression ? 'label-wrapper' : 'clear-mins'}>
+    <div bind:this={element} class={compression ? 'label-wrapper' : 'clear-mins'}>
       <MilestoneSelector
         {kind}
         {size}
@@ -112,6 +115,7 @@
   {/if}
 {:else}
   <div
+    bind:this={element}
     class="flex flex-wrap clear-mins"
     class:minus-margin={kind === 'list-header'}
     class:label-wrapper={compression}
diff --git a/plugins/view-resources/src/components/HyperlinkEditor.svelte b/plugins/view-resources/src/components/HyperlinkEditor.svelte
index 92d6b704d8..11e3bc9fc6 100644
--- a/plugins/view-resources/src/components/HyperlinkEditor.svelte
+++ b/plugins/view-resources/src/components/HyperlinkEditor.svelte
@@ -60,11 +60,11 @@
 >
   <svelte:fragment slot="content">
     {#if title}
-      <span class="caption-color overflow-label pointer-events-none">{title}</span>
+      <span class="label caption-color overflow-label pointer-events-none">{title}</span>
     {:else if value}
-      <span class="caption-color overflow-label pointer-events-none">{value}</span>
+      <span class="label caption-color overflow-label pointer-events-none">{value}</span>
     {:else}
-      <span class="content-dark-color pointer-events-none">
+      <span class="label content-dark-color pointer-events-none">
         <Label label={placeholder} />
       </span>
     {/if}
diff --git a/plugins/view-resources/src/components/list/ListItem.svelte b/plugins/view-resources/src/components/list/ListItem.svelte
index 773c16a91e..c3f162fb57 100644
--- a/plugins/view-resources/src/components/list/ListItem.svelte
+++ b/plugins/view-resources/src/components/list/ListItem.svelte
@@ -84,6 +84,11 @@
   onMount(() => {
     dispatch('on-mount')
   })
+  let minWidth: number | undefined = undefined
+  const sizes = new Map<number, number>()
+  const calcSizes = (): void => {
+    minWidth = sizes.size > 0 ? Array.from(sizes.values()).reduce((a, b) => a + b, 0) : undefined
+  }
 </script>
 
 <!-- svelte-ignore a11y-no-static-element-interactions -->
@@ -147,14 +152,19 @@
         {/if}
         <GrowPresenter />
         {#if !compactMode}
-          <div class="compression-bar">
-            {#each model.filter((p) => p.displayProps?.compression === true) as attrModel}
+          <div class="compression-bar" style:min-width={`${minWidth}px`}>
+            {#each model.filter((p) => p.displayProps?.compression === true) as attrModel, index}
               <ListPresenter
                 {docObject}
                 attributeModel={attrModel}
                 props={getProps(props, $restrictionStore.readonly)}
                 value={getObjectValue(attrModel.key, docObject)}
                 onChange={getOnChange(docObject, attrModel)}
+                on:resize={(e) => {
+                  if (e.detail == null) return
+                  sizes.set(index, e.detail)
+                  calcSizes()
+                }}
               />
             {/each}
           </div>
diff --git a/plugins/view-resources/src/components/list/ListPresenter.svelte b/plugins/view-resources/src/components/list/ListPresenter.svelte
index bdb9f57c13..9ac7737c86 100644
--- a/plugins/view-resources/src/components/list/ListPresenter.svelte
+++ b/plugins/view-resources/src/components/list/ListPresenter.svelte
@@ -13,6 +13,7 @@
 // limitations under the License.
 -->
 <script lang="ts">
+  import { createEventDispatcher } from 'svelte'
   import core, { Doc } from '@hcengineering/core'
   import { AttributeModel } from '@hcengineering/view'
   import { FixedColumn } from '../..'
@@ -26,6 +27,8 @@
   export let hideDivider: boolean = false
   export let compactMode: boolean = false
 
+  const dispatch = createEventDispatcher()
+
   $: dp = attributeModel?.displayProps
 
   function joinProps (attribute: AttributeModel, object: Doc, props: Record<string, any>) {
@@ -35,6 +38,10 @@
     }
     return { object, ...clearAttributeProps, space: object.space, ...props }
   }
+  const translateSize = (e: CustomEvent): void => {
+    if (e.detail === undefined) return
+    dispatch('resize', e.detail)
+  }
 </script>
 
 {#if dp?.dividerBefore === true && !hideDivider}
@@ -49,6 +56,7 @@
       kind={'list'}
       {compactMode}
       {...joinProps(attributeModel, docObject, props)}
+      on:resize={translateSize}
     />
   </FixedColumn>
 {:else}
@@ -59,5 +67,6 @@
     kind={'list'}
     {compactMode}
     {...joinProps(attributeModel, docObject, props)}
+    on:resize={translateSize}
   />
 {/if}
diff --git a/services/github/github-resources/src/components/presenters/GithubIssuePresenter.svelte b/services/github/github-resources/src/components/presenters/GithubIssuePresenter.svelte
index 6e37564a17..08fc1a9017 100644
--- a/services/github/github-resources/src/components/presenters/GithubIssuePresenter.svelte
+++ b/services/github/github-resources/src/components/presenters/GithubIssuePresenter.svelte
@@ -2,11 +2,13 @@
   import { Issue } from '@hcengineering/tracker'
 
   import { getClient } from '@hcengineering/presentation'
+  import type { ButtonKind } from '@hcengineering/ui'
   import { HyperlinkEditor } from '@hcengineering/view-resources'
   import github from '../../plugin'
   import { integrationRepositories } from '../utils'
 
   export let value: Issue
+  export let kind: ButtonKind = 'ghost'
 
   $: ghIssue = getClient().getHierarchy().asIf(value, github.mixin.GithubIssue)
 
@@ -14,14 +16,12 @@
 </script>
 
 {#if ghIssue !== undefined && ghIssue.url !== '' && repository !== undefined}
-  <div class="flex flex-row-center">
-    <HyperlinkEditor
-      readonly
-      icon={github.icon.Github}
-      kind={'ghost'}
-      value={ghIssue.url}
-      placeholder={github.string.Issue}
-      title={`${repository.name}`}
-    />
-  </div>
+  <HyperlinkEditor
+    readonly
+    icon={github.icon.Github}
+    {kind}
+    value={ghIssue.url}
+    placeholder={github.string.Issue}
+    title={`${repository.name}`}
+  />
 {/if}