Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy pandas function in kabuki.analyze._post_pred_generate when append_data=True #34

Open
zenkavi opened this issue Feb 9, 2018 · 0 comments

Comments

@zenkavi
Copy link

zenkavi commented Feb 9, 2018

Hi,

I had some trouble using kabuki.analyze.post_pred_gen with HDDMRegressor class when append_data=True. I debugged it by replacing
sampled_data = sampled_data.join(data.reset_index(), lsuffix='_sampled')
with
sampled_data = sampled_data.merge(data, left_index=True, right_index=True, suffixes=('_sampled', ''))
in kabuki.analyze._post_pred_generate.
My understanding is that join is a legacy pandas function and merge works better but you might have a more elegant solution for this. Let me know if you'd like me send a pr or if you change the code in this or another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant